From: Peter Palfrader Date: Mon, 6 Oct 2008 12:10:08 +0000 (+0200) Subject: [project @ peter@palfrader.org-20081006121008-cnkfzn2ler3d933h] X-Git-Url: https://wiki.adam-barratt.org.uk/gitweb/?a=commitdiff_plain;h=dcc64f51dcda6cdea0b25142680ef6dba28e16d5;p=mirror%2Fdsa-nagios.git [project @ peter@palfrader.org-20081006121008-cnkfzn2ler3d933h] dsa-check-hpacucli: Do not create the 'Failed' array while checking if an entry is in there. If it doesn't exist that's also good --- diff --git a/dsa-nagios-nrpe-config/debian/changelog b/dsa-nagios-nrpe-config/debian/changelog index c6a6f8a..74b0ab4 100644 --- a/dsa-nagios-nrpe-config/debian/changelog +++ b/dsa-nagios-nrpe-config/debian/changelog @@ -1,3 +1,10 @@ +dsa-nagios-nrpe-config (61) unstable; urgency=low + + * dsa-check-hpacucli: Do not create the 'Failed' array while checking if an + entry is in there. If it doesn't exist that's also good. + + -- Peter Palfrader Mon, 06 Oct 2008 14:08:30 +0200 + dsa-nagios-nrpe-config (60) unstable; urgency=low * Add dsa-check-raid-areca. diff --git a/dsa-nagios-nrpe-config/dsa-check-hpacucli b/dsa-nagios-nrpe-config/dsa-check-hpacucli index 4ee5bbe..ce0910e 100755 --- a/dsa-nagios-nrpe-config/dsa-check-hpacucli +++ b/dsa-nagios-nrpe-config/dsa-check-hpacucli @@ -120,7 +120,7 @@ for my $slot (sort @controllers) { # sometimes stuff breaks and they fall back to 10mb/sec. for my $drive (@drives) { # skip drives that are known to have failed - next if (grep {$drive eq $_} @{$status{'Failed'}}); + next if (exists $status{'Failed'} && grep {$drive eq $_} @{$status{'Failed'}}); my $type; if ($drive =~ /^[0-9]+:[0-9]+$/) { # scsi drives $type = 'SCSI';