dsa-check-running-kernel: check if 'strings' is installed and complain nicely if...

diff --git a/dsa-nagios-checks/checks/dsa-check-running-kernel b/dsa-nagios-checks/checks/dsa-check-running-kernel
index 78255f7..452c8c1 100755 (executable)
--- a/dsa-nagios-checks/checks/dsa-check-running-kernel
+++ b/dsa-nagios-checks/checks/dsa-check-running-kernel
@@ -159,6 +159,10 @@ for on_disk in \
        "/boot/kfreebsd-`uname -r`.gz"; do
 
        if [ -e "$on_disk" ]; then
+               if [ ! -x "$(which strings)" ]; then
+                       echo "UNKNOWN: 'strings' command missing, perhaps install binutils?"
+                       exit $UNKNOWN
+               fi
                if [ "${on_disk/vmlinu}" != "$on_disk" ]; then
                        on_disk_version="`get_image_linux "$on_disk" | strings | grep 'Linux version' | head -n1`"
                        [ -z "$on_disk_version" ] || break

diff --git a/dsa-nagios-checks/debian/changelog b/dsa-nagios-checks/debian/changelog
index 5d52b0d..f2f561c 100644 (file)
--- a/dsa-nagios-checks/debian/changelog
+++ b/dsa-nagios-checks/debian/changelog
@@ -5,8 +5,10 @@ dsa-nagios-checks (8x) xnstable; urgency=low
   * dsa-check-hpacucli add --ignore-transfer-speed option.
   * Add dsa-check-ups.
   * Add dsa-check-hpacucli-enclosure.
+  * dsa-check-running-kernel: check if 'strings' is installed and
+    complain nicely if it isn't instead of falling over. [Uli Martens]
 
- -- Peter Palfrader <weasel@debian.org>  Tue, 24 Aug 2010 13:02:38 +0200
+ -- Peter Palfrader <weasel@debian.org>  Sun, 05 Sep 2010 11:33:10 +0200
 
 dsa-nagios-checks (87) unstable; urgency=low